Skip to content

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Sep 4, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Ported a lot of test from the legacy infrastructure to the current one.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmaglie cmaglie added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Sep 4, 2023
@cmaglie cmaglie added this to the Arduino CLI 1.0 milestone Sep 4, 2023
@cmaglie cmaglie self-assigned this Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.13% ⚠️

Comparison is base (3f9373a) 63.40% compared to head (c4f9601) 63.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2294      +/-   ##
==========================================
- Coverage   63.40%   63.27%   -0.13%     
==========================================
  Files         219      219              
  Lines       19536    19536              
==========================================
- Hits        12386    12361      -25     
- Misses       6069     6091      +22     
- Partials     1081     1084       +3     
Flag Coverage Δ
unit 63.27% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie merged commit 0af0b44 into arduino:master Sep 4, 2023
@cmaglie cmaglie deleted the legacy_tests branch September 4, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants